Reorganize repo: grouped config files inside spyderlib/config #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one needs a rebase :-) |
|
@ccordoba12 done! |
| @@ -10,7 +10,7 @@ | |||
| from sphinx import __version__ as sphinx_version | |||
|
|
|||
| # Local imports | |||
| from spyderlib.config import CONF | |||
| from spyderlib.config.config import CONF | |||
There was a problem hiding this comment.
This an error, right? It should be
from spyderlib.config.main import CONF
|
I really don't understand how our tests are passing with the errors I pointed out. How can that be the case @goanpeca? |
|
The imports were located in if statements... so they were not being triggered...and the one in the inspector was a sphinx ... so there I do not really know. |
|
I did a last review, and everything seems in order now :-) Weird that our tests didn't fail... |
ccordoba12
added a commit
that referenced
this pull request
Aug 8, 2015
Reorganize repo: grouped config files inside spyderlib/config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo organization (related to issue #1320)
All dangling
****config.pyfiles were grouped into a single folder,spyderlib/config/