Add "close all but this" and "close all to the right" entries to the Editor context menu

[igordsm]

Fixes #2354

---

The menu items were added before the "new window" action.

[goanpeca]

@igordsm thanks for working on this :).

Can you please post a screenshot of how the menu looks?

Cheers

[petebachant]

Nice!

However, I just ran @igordsm's version via bootstrap.py and these menu items did not work as expected. "Close all to the right" works more like "Close all to the left". Both "Close all to the right" and "Close all but this" do not keep the clicked tab, but instead keep the one that was in focus.

Could a test be written to mimic this error?

[igordsm]

Hey @petebachant , I just notice the left/right thing and will update the PR in a few moments.

About the behaviour of clicked vs selected tab, the same happens with the "Go to line" option. Is this expected?

[goanpeca]

Hmmm funny, I think the correct behavior should be to affect the right clicked tab... so maybe we need to file a bug for the gotoline @ccordoba12?

[igordsm]

As far as I understand, both the code that I made and the code in gotoline depend on the currently selected tab. Maybe the solution could be activate the tab when using the right click?

[ccordoba12]

@igordsm, this needs a rebase or a merge with master.

[igordsm]

@ccordoba12 I just merged with master and added a commit to activate tabs on right click. This way both gotoline and the new commands will affect the clicked tab.

[ccordoba12]

Please merge again with master. We had some problems with our testing machinery on Windows, but I think that's fixed now :-)

[igordsm]

@ccordoba12 Remerged and both checks passed. Thank you.

[igordsm]

Can someone merge or look at this again, please?

[goanpeca]

@igordsm

What happened with

As far as I understand, both the code that I made and the code in gotoline depend on the currently selected tab. Maybe the solution could be activate the tab when using the right click?

Also, why not make Close all to the left?, just curious,...

[igordsm]

@goanpeca The tabs are activated on right-click, so now "go to line" and the new options affect the clicked tab.
For some reason I never found a "close all left" option in other programs...

[goanpeca]

@igordsm I see that you are making a PR from your master into spyder master.

We normally work using branches. Did you take a look at these instructions?

[goanpeca]

@igordsm ?

[goanpeca]

@ccordoba12 , @Nodd @igordsm ?

[ccordoba12]

Looks good to me.