-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using IPython.lib.kernel 0.13.2 shim and add initial support for Jupyter #2486
Conversation
OK, this solves the last issue I had with Jupyter, where find_connection_file has a slightly different signature. |
Minor correction: jupyter connection files go in JUPYTER_DATA_DIR, not ~/.jupyter, and Jupyter has no profiles, so there is no |
Thanks @minrk I edited the description. |
could it ship in coming Spyder 2.3.5 ? |
@stonebig good point, I guess we should do it if 3.0 does not ship before IPython 4.0. |
So with this PR we will be compatible with IPython/Jupyter 4.0? |
Yes, it works with the current development version. |
Ok, thanks @SylvainCorlay for the confirmation. @stonebig, I'll backport these changes to release them in 2.3.5. |
Thanks. |
@SylvainCorlay, there are other instances where we're using
What should we do with them? |
|
I'm going to merge this to have some kind of support for Jupyter 4.0. Later we can see what we can do about 3. @SylvainCorlay, please open a new PR with the comments you suggest. I guess there are going to be several of them :-) |
Stop using IPython.lib.kernel 0.13.2 shim and add initial support for Jupyter
Thanks. I am looking into the points you raised and it is not immediate. I should come up with another PR soon. |
Ok, thanks! |
find_connection_file
was being imported fromIPython.lib.kernel
which is a shim toIPython.kernel.connect
since 1.0. Therefore, this does not change anything for IPython 1.0 to 3.2. We are just using a more direct path.IPython.lib.kernel
is a shim toipykernel.connect
IPython.kernel.connect
is a shim as well, which first imports everything fromipykernel.connect
and then everything fromjupyter_client.connect
. The latter sets the default directory for connection files from~/.ipython/profile_*/security
toJUPYTER_DATA_DIR
, which is the correct behavior.