Print git revision and branch in bootstrap.py instead of mercurial #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nodd, this one failed, according to travis |
|
Forgot about python3 compatibility... Travis is really useful ! 😄 |
|
Now Travis is happy ! |
|
Getting the current git branch is not working in Python 3 (or at least is not shown after running The branch I'm working on is |
|
It should work now, and the code is clearer too. |
|
Have you tested this PR on Windows? If not, could you do it to see if there are no problems there? |
|
I tested on windows, seems to be working fine |
|
Great, thanks @goanpeca. Merging then ;-) |
ccordoba12
added a commit
that referenced
this pull request
Jun 1, 2015
Print git revision and branch in bootstrap.py instead of mercurial
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootstrap.py still searched for a mercurial revision number. Now it uses git.
I added the search for the branch name.