Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some completion issues on the Editor (issue #2352) #2357

Merged
merged 5 commits into from
Apr 24, 2015

Conversation

blink1073
Copy link
Contributor

Fixes #2352.

@ccordoba12 ccordoba12 added this to the v3.0 milestone Apr 24, 2015
@ccordoba12
Copy link
Member

Thanks a lot for the ultra fast response ;-) I verified that all errors I found are fixed now!

There is one last thing I forgot to mention in issue #2352. When you write

import <Tab>

the full list of modules is not returned now, while it was before.

Would you mind to fix this also as part of this PR? Thanks :-)

@blink1073
Copy link
Contributor Author

Fixed!

@ccordoba12
Copy link
Member

Thanks, it's working now :-)

There is yet another thing I just find out. We should use the new module icon only when doing

import fo<Tab>

or

from ba<Tab>

but not when doing

from foo import ba<Tab>

because that shows every completion as a module, which is obviously wrong :-)

If in this last case our completion libraries can't introspect types (as I think it's the case), we need to show no icons at all :-)

@ccordoba12 ccordoba12 changed the title Fix completion issues from #2352 Fix some completion issues on the Editor (issue #2352) Apr 24, 2015
@blink1073
Copy link
Contributor Author

Okay, now we get icons for import nu<Tab> and from nu<Tab>, but not from numpy import a<Tab>.

@blink1073
Copy link
Contributor Author

(unless you have Jedi of course 😄)

@ccordoba12
Copy link
Member

Great work man!! Merging :-)

ccordoba12 added a commit that referenced this pull request Apr 24, 2015
Fix some completion issues on the Editor (issue #2352)
@ccordoba12 ccordoba12 merged commit 5e559ce into spyder-ide:master Apr 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some issues with code completion in the Editor
3 participants