-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some completion issues on the Editor (issue #2352) #2357
Fix some completion issues on the Editor (issue #2352) #2357
Conversation
Thanks a lot for the ultra fast response ;-) I verified that all errors I found are fixed now! There is one last thing I forgot to mention in issue #2352. When you write
the full list of modules is not returned now, while it was before. Would you mind to fix this also as part of this PR? Thanks :-) |
Fixed! |
Thanks, it's working now :-) There is yet another thing I just find out. We should use the new module icon only when doing
or
but not when doing
because that shows every completion as a module, which is obviously wrong :-) If in this last case our completion libraries can't introspect types (as I think it's the case), we need to show no icons at all :-) |
Okay, now we get icons for |
(unless you have Jedi of course 😄) |
Great work man!! Merging :-) |
Fix some completion issues on the Editor (issue #2352)
Fixes #2352.