Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Catch error when checking for updates (Update Manager) #23420

Merged
merged 7 commits into from
Jan 15, 2025

Conversation

jsbautista
Copy link
Contributor

@jsbautista jsbautista commented Jan 6, 2025

Description of Changes

Spyder catches the exception caused by certificate related errors. When this exception occurs, an informative message is displayed

PreviewOSError

Issue(s) Resolved

Fixes #22834

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct:
@jsbautista

@dalthviz dalthviz modified the milestones: 6.04, v6.0.4 Jan 7, 2025
@jsbautista jsbautista changed the title [WIP] PR: Error when checking for updates PR: Error when checking for updates Jan 13, 2025
@ccordoba12 ccordoba12 changed the title PR: Error when checking for updates PR: Catch error when checking for updates (Update Manager) Jan 13, 2025
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista for your work on this!

spyder/plugins/updatemanager/widgets/update.py Outdated Show resolved Hide resolved
spyder/plugins/updatemanager/workers.py Outdated Show resolved Hide resolved
spyder/plugins/updatemanager/workers.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last suggestion @jsbautista, then this should be ready to be merged.

spyder/plugins/updatemanager/workers.py Outdated Show resolved Hide resolved
@jsbautista jsbautista requested a review from ccordoba12 January 15, 2025 20:23
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsbautista!

@ccordoba12 ccordoba12 merged commit 1e20d17 into spyder-ide:master Jan 15, 2025
17 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 6.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when checking for updates
3 participants