Finish Introduction tour #2331
Finish Introduction tour #2331
Conversation
IMO, it's easier to identify them that way
|
Hey @ccordoba12 thanks for working on this. It looks fine on a quick look, but there is an issue that needs to be solved, maybe the ipython console is not intalled, so we need to include this in the logic of the tours.py |
| "code in this console. This will be useful to show " | ||
| "you other important Spyder features." % \ | ||
| qtconsole_link), | ||
| 'widgets': [sw.ipython_console], |
There was a problem hiding this comment.
This will blow if ipython is not installed...
There was a problem hiding this comment.
Yes, we need to verify that ipython_console exists before adding this part to the tour.
There was a problem hiding this comment.
@ccordoba12 can you please use 'Text {0}'.format(variable) instead of %, I think is better and more flexible.
|
What should be the default behavior when a widget is not there? Depending on this I can make a PR to correct this, and also include the suggestion of @Nodd of using a dummy dockwidget instead of making it transparent to events (the temporal fix used right now...) |
|
It would be bad to skip it completely since the tour is there to show all features of spyder to new users. Maybe add a warning that the corresponding widget it not active ? |
|
The only plugin that can be missing right now is the IPython console (which is loaded on demand). All other plugins (even the Pylint one) load fine. But @Nodd has a good point: if the IPython Console is missing, the tour should show a warning and guide the user on how to install it. |
|
There is also the case where a panel is not enabled. Is this manager ? (if I remember well, @goanpeca told me it was working, but it was a long time ago) |
|
If the panel is not enabled, it should be a problem... as far as I remember (it will be enabled and brought to the front) Sure, we can then display a replacement content indicating how to install ipython. |
…Internal Console - We really don't want to talk about the Internal Console in the Intro tour :-)
|
@goanpeca, this is ready for a review. I added reasonable contents to all the Intro tour slides. |
|
Cool, will test it later on :-) |
|
@goanpeca, I think this is ready for merge too ;-) |
|
Go for it! |
|
Oki doki! ;-) |
This PR adds the missing contents of the Introduction tour.
I decided to create it given that this was @goanpeca's work, so I'd like to know his thoughts about my additions.