Use empty string instead of None for fallback. Fixes #2313. #2316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/spyderlib/utils/introspection/plugin_manager.py b/spyderlib/utils/introspection/plugin_manager.py
index 9685848..0db27dd 100644
--- a/spyderlib/utils/introspection/plugin_manager.py
+++ b/spyderlib/utils/introspection/plugin_manager.py
@@ -158,7 +158,7 @@ class CodeInfo(object):
break
position -= 1
else:
- self.docstring = None
+ self.docstring = ''
self.position = position
@@ -167,8 +167,8 @@ class CodeInfo(object):
self.column = 0
self.line_num = 0
self.line = ''
- self.obj = None
- self.full_obj = None
+ self.obj = ''
+ self.full_obj = ''
else:
self._get_info()
@@ -229,6 +229,7 @@ class CodeInfo(object):
right += 1
if left and right < len(self.source_code):
return self.source_code[left: right]
+ return ''
def __eq__(self, other):
try:
|
Would you mind to fix the description of this PR? ;-) |
|
Whoops, done! |
ccordoba12
added a commit
that referenced
this pull request
Apr 16, 2015
Use empty string instead of None for fallback. Fixes #2313.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes error in introspection found in #2313, due to
CodeInfousingNoneas the defaultobjtoken.