PR: Restore TMPDIR in the kernel if it's available in the system
#22394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to restore TMPDIR there if it exists on the Spyder side.
…s.git --branch=restore-tmpdir --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "b6ffbb42b5" upstream: origin: "https://github.com/ccordoba12/spyder-kernels.git" branch: "restore-tmpdir" commit: "b6ffbb42b5" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "ea10886"
|
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-08-29 14:50:39 UTC |
ecfae18 to
b8590e9
Compare
TMPDIR in the kernel if it's available in the systemTMPDIR in the kernel if it's available in the system
…r-kernels.git --branch=master --update --force external-deps/spyder-kernels subrepo: subdir: "external-deps/spyder-kernels" merged: "80a08c8d16" upstream: origin: "https://github.com/spyder-ide/spyder-kernels.git" branch: "master" commit: "80a08c8d16" git-subrepo: version: "0.4.9" origin: "https://github.com/ingydotnet/git-subrepo" commit: "ea10886" [ci skip]
|
I added a test to verify that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
TMPDIRenv var to kernels (IPython console) #22382.TMPDIRis a system env var on macOS, so we can't simply remove it in the kernel.TMPDIRenv var if it was available on the Spyder side spyder-kernels#500.Issue(s) Resolved
See #22382 (comment) for the details.
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12