PR: Use jupyter_server instead of jupyterhub for remote client plugin
#22155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith jupyter_server api
|
Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-06-12 00:10:13 UTC |
|
Checking this seems like I was able to connect to the server however, I still experienced the restart behavior :/ Tested with my Linux VM (from my Windows machine). Here the debug log I was able to generated: Here my conda env details: Let me know if you need further info or want me to try something specific in my setup! |
Two issues are happening with @dalthviz test. Firstly, he's getting the ipykernel bug and from my testing, this prevents the jupyter from communicating with the kernel leading to the consoles being unresponsive, therefore requiring the #22137 fix. Another key point that could be a factor in the second bug, is a concurrency issue when connecting/installing/starting the remote server which I've fixed in the latest commits. However, I'm unsure of the main cause of the second bug from the logs. Although both of them certainly are responsible for the restarting errors.
In @ccordoba12's case, since he doesn't present any ipykernel error, testing this branch without #22137 is sufficient. And with the latest fixes, there shouldn't indeed be any issues. |
ccordoba12
approved these changes
Jun 17, 2024
|
Note: It seems @dalthviz reported problems are related to networking issues, so I'm going to merge this one. However, we'll keep investigating if that's the case and try to address them before the release of 6.0 final. |
jupyter_server instead of jupyterhub for remote client plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @hlouzada