PR: Change how Spyder determines if it is a conda-based app #21646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
4a7c266 to
4abb3b9
Compare
1f12d10 to
c597378
Compare
ccordoba12
approved these changes
Dec 30, 2023
492b0b9 to
323fdb0
Compare
3a6cd04 to
ebc9d79
Compare
8e4ac76 to
3d08369
Compare
Conda install of spyder package clobbers Menu/* and breaks the app. Including Menu in standard conda package makes standard installs register as conda-based apps if checking for spyder-menu.json. So the solution is to use a file that only the installer will create: conda-based-app in the Menu directory.
…t v2 support; remove bundle_tools_3 channel dependence. Sometime between mamba=1.4.2 and mamba=1.5.6, mamba mambabuild generates error "ValueError: unrecognized 'args' object". This does not affect conda mambabuild. Ensure correct versions of conda and menuinst are installed in base environment. Now that all packages are in conda-forge, strict channel priority will continue to work but flexible doesn't hurt.
Generally, macOS uses BSD sed and Linux uses GNU sed. However, in some circumstances (CI macOS arm64) it appears that macOS may be using GNU instead of BSD. Therefore it is best to check sed directly for BSD/GNU rather than using the platform as a proxy. Remove patch for old-style markers.
Add aliases to all shell init files in user mode. Fixed issue where post-install script would prematurely exit when adding alias to shell init files. Use menuinst to remove shortcut when uninstalling.
Show progress notifications (macOS)
3d08369 to
f1ce092
Compare
|
@mrclary, could you check why the Windows installer is not passing the test for it? That way we could merge this one. |
|
Closed in favor of #21647 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
conda-based-appnext tospyder-menu.json.is_conda_based_appchecks forconda-based-appinstead ofspyder-menu.json. This is required sincespyder-menu.jsonis will not be unique to our standalone installer.Issue(s) Resolved
Partially addresses #21640