-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Start spinner in dependencies dialog only when it's visible and make some improvements to the dialog's UI #21616
PR: Start spinner in dependencies dialog only when it's visible and make some improvements to the dialog's UI #21616
Conversation
This is necessary because that version has new API to start/stop spin animations.
This fixes a UI error there.
- Add notes to a single list. - Add better title and remove icon because it doesn't look good. - Add more margins so the content looks better.
Also, set the same css for enabled and disabled buttons in dialogs. That's necessary to correctly change the state of a button from disabled to enabled.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
a22c572
to
e90b5a3
Compare
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2023-12-15 18:30:18 UTC |
eada236
to
7c20b22
Compare
Also, change color of dependency_ok icon to make stand out in relation to the text.
7c20b22
to
5a69be4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ccordoba12 ! I just left a comment pointing that maybe it could be worthy to create a follow-up issue for the Find in Files segfault that was happening and that is handled here by skipping the main_widget.py
file from the modules_test
script.
Other than that this LGTM 👍
Edit - Also, just in case, this is how the dialog is looking when waiting:
if [[ $f == spyder/plugins/findinfiles/widgets/main_widget.py ]]; then | ||
continue | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we created an issue to follow-up on this file run giving a segfault?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's necessary because I was unable to reproduce locally the segfault generated when running this file and it seems random in CIs.
Description of Changes
dependency_ok
icon so that it stands out in relation to the text.Visual changes
Before
After
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: