PR: Change style of border around thumbnail of current plot

[jitseniesen]

Description of Changes

• Wrote at least one-line docstrings (for any new functions) N/A
• Added unit test(s) covering the changes (if testable) N/A

• Included a screenshot or animation (if affecting the UI, see Licecap)

Change the border around the thumbnail of the current plot in the Plots pane to 3px wide and gray (COLOR_TEXT_3) for clarity and consistency with the overall styling. This style was suggested in this comment.

Screenshot after the change in dark theme:

Screenshot after the change in light theme:

Issue(s) Resolved

Fixes #21046

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Jitse Niesen

[ccordoba12]

Thanks @jitseniesen for your work on this! I think the new border style looks quite good in the light theme but not so much in the dark one because it blends a bit with the plot's own color.

@conradolandia, what do you think?

[conradolandia]

I agree with you, @ccordoba12. Let's try B70 (from the Gray class):

[jitseniesen]

This is what it looks like with Gray.B70 in dark mode:

[conradolandia]

I am thinking we should go back to the blue. Preserving the line thickness, but going back to the blue color we had before. That will look good in both the dark and light theme.

[jitseniesen]

I am not certain that my previous screenshot was correct. This is what it really looks like with Gray.B70:

This is the original blue color, but with 3px thickness instead of the original 2px thickness. I think it is clearer than before and thus an improvement.

Same in light mode:

[ccordoba12]

This is the original blue color, but with 3px thickness instead of the original 2px thickness. I think it is clearer than before and thus an improvement.

I think so too. So, I propose that we should go with this option instead.

@conradolandia, what do you think?

[conradolandia]

I think this option works fine enough, yes.

[jitseniesen]

Great, I squashed the commits in one, as it is basically a one-character change now.

[ccordoba12]

Thanks @jitseniesen!

Note: The error in our test suite is unrelated to this.

[jmshon-ssu]

Please unsubscribe me. Thanks,

…

________________________________ From: Carlos Cordoba ***@***.***> Sent: Wednesday, January 3, 2024 10:17 AM To: spyder-ide/spyder ***@***.***> Cc: Subscribed ***@***.***> Subject: Re: [spyder-ide/spyder] PR: Change style of border around thumbnail of current plot (PR #21598) @ccordoba12 approved this pull request. Thanks @jitseniesen<https://github.com/jitseniesen>! Note: The error in our test suite is unrelated to this. — Reply to this email directly, view it on GitHub<#21598 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BBN3IHZD3DONFSGK5LPZKEDYMSWTXAVCNFSM6AAAAABANYY7NGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQMBRGI3TAMBXGU>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>