PR: Fix enabling/disabling individual providers (Completions) #21463
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The start and shutdown providers logic was missing updating the
language_status
attribute which is used to determine the providers that are available for a certain language. In the case of a completion request all responses for the available providers need to be aggregated, so all providers need to be waited before a response is made available. This caused that by disabling one of the providers no reponse was able to be retrieved but still that provider was expected to give a reponseAlso, there is some logic to handle a timeout but only the LSP provider is marked as slow and at least 3 providers need to be marked as slow to trigger the logic. For more details about that see:
spyder/spyder/plugins/completion/plugin.py
Lines 1038 to 1044 in 6d53101
Issue(s) Resolved
Fixes #21462
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: dalthviz