Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Follow-up to using the requests library for updates #21433

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Oct 18, 2023

@mrclary mrclary self-assigned this Oct 18, 2023
@ccordoba12 ccordoba12 changed the title PR: requests follow-up PR: Follow-upn to using the requests library for updates Oct 19, 2023
@ccordoba12 ccordoba12 added this to the v5.5.0 milestone Oct 19, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion for you @mrclary, the rest looks good to me.

spyder/workers/updates.py Outdated Show resolved Hide resolved
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@ccordoba12 ccordoba12 changed the title PR: Follow-upn to using the requests library for updates PR: Follow-up to using the requests library for updates Oct 19, 2023
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise LGTM. Thanks @mrclary !

spyder/workers/updates.py Outdated Show resolved Hide resolved
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 39dc4c4 into spyder-ide:5.x Oct 19, 2023
22 checks passed
ccordoba12 added a commit that referenced this pull request Oct 19, 2023
@mrclary mrclary deleted the requests-follow-up branch February 5, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants