-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Follow-up to using the requests
library for updates
#21433
Conversation
requests
follow-uprequests
library for updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small suggestion for you @mrclary, the rest looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
requests
library for updatesrequests
library for updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion, otherwise LGTM. Thanks @mrclary !
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mrclary!
Apply suggestions from code review:
https://github.com/spyder-ide/spyder/pull/21423/files/314c3eab9735500ca249619300fcca3628fa5be6