Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Change name of workflow for conda-based installers #21424

Merged
merged 4 commits into from
Oct 18, 2023

Conversation

mrclary
Copy link
Contributor

@mrclary mrclary commented Oct 12, 2023

Description of Changes

Change the name of the workflow for conda-based installers to be more generic. When merging into master, the name of the workflow should be adopted in master as well so that the workflow in both branches has the same name parameter.

@mrclary mrclary self-assigned this Oct 12, 2023
@mrclary mrclary force-pushed the installer-workflow branch from be84454 to a745967 Compare October 12, 2023 22:29
@mrclary mrclary requested a review from ccordoba12 October 12, 2023 22:51
@mrclary mrclary marked this pull request as ready for review October 12, 2023 22:51
@mrclary mrclary added this to the v5.5.0 milestone Oct 12, 2023
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a suggestion for you @mrclary.

README.md Outdated Show resolved Hide resolved
@ccordoba12 ccordoba12 changed the title Change name of workflow for conda-based installers. PR: Change name of workflow for conda-based installers Oct 13, 2023
@mrclary mrclary force-pushed the installer-workflow branch from 12d435b to 3e63237 Compare October 16, 2023 20:47
mrclary and others added 4 commits October 18, 2023 09:11
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@mrclary mrclary force-pushed the installer-workflow branch from 81c3032 to 0dddeca Compare October 18, 2023 16:11
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mrclary!

@ccordoba12 ccordoba12 merged commit 1c90bcc into spyder-ide:5.x Oct 18, 2023
ccordoba12 added a commit that referenced this pull request Oct 18, 2023
@mrclary mrclary deleted the installer-workflow branch February 5, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants