Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Migrate the Spyder update mechanism to the conda-based standalone application #20900

Closed
wants to merge 51 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
51 commits
Select commit Hold shift + click to select a range
ab2d85b
Revert "Auxiliary commit to revert individual files from 3dd22c43522b…
mrclary May 15, 2023
6c42ae0
Update message boxes now that updates will always be >6.0.0
mrclary Sep 28, 2023
66a04dd
Convert update mechanism to conda-based installers.
mrclary May 2, 2023
70e1252
Add logging messages
mrclary May 4, 2023
cada5fc
Fix issue where releases could be empty if current version is non-sta…
mrclary May 4, 2023
bf652a6
First check for updates from github:
mrclary May 4, 2023
09583ae
Create single install method.
mrclary May 7, 2023
edaad51
Fix issue where update status was not set when error occurs on startup.
mrclary May 5, 2023
13ecda0
Do not set status to CHECKING while waiting for timer at startup. Ins…
mrclary May 5, 2023
88fab90
Update unit tests
mrclary May 5, 2023
4ede59a
Allow update with conda
mrclary May 6, 2023
9fd0c73
Include all releases, unless current version is stable
mrclary May 6, 2023
83fb3f5
Allow installing after download complete
mrclary May 6, 2023
fee61b6
Fix PermissionError Operation not permitted. os.remove cannot remove …
mrclary May 6, 2023
05d4e81
Alert user to download error and do not proceed with installation
mrclary May 8, 2023
744e9de
Set application status to NO_STATUS if error.
mrclary May 8, 2023
c7c4e99
Use x86_64 for Windows machine architecture. Fix this later
mrclary May 8, 2023
562e43d
Fix "TypeError: _progress_reporter() missing 1 required positional ar…
mrclary May 8, 2023
4e26b02
Improve debug logging for errors in workers
mrclary May 8, 2023
e827776
Rename start_installation -> start_download
mrclary May 9, 2023
7359034
Rename cancel_installation -> cancel_download
mrclary May 9, 2023
5adffc3
Rename install -> start_installation
mrclary May 9, 2023
60f3aa0
Rename UpdateInstallation -> UpdateDownload; _installation_widget -> …
mrclary May 9, 2023
70a9167
Rename _change_update_installation_status -> _change_update_download_…
mrclary May 10, 2023
612da33
If proceeding with install, request install on close and quit Spyder
mrclary Jun 2, 2023
482a282
Use update/install shell scripts.
mrclary Sep 28, 2023
11e1125
Prevent the Application plugin container's on_close method from being…
mrclary Jun 3, 2023
9eba260
Fix download url to resolve any release
mrclary Jun 26, 2023
ac54ff6
Fix issue where update dialog menu could attempt download instead of …
mrclary Jun 27, 2023
48684a9
Debug logging message shows available versions.
mrclary Sep 20, 2023
e56cf51
Set application_update_status for all distributions
mrclary Sep 20, 2023
a1575fd
Refactor check_updates on startup
mrclary Sep 20, 2023
76382f2
Move download error message box to UpdateInstallerDialog.
mrclary Sep 20, 2023
e07c8b3
Fix resetting startup
mrclary Sep 28, 2023
9a6b9ee
Fix update status.
mrclary Sep 28, 2023
5f94290
Fix extraneous argument to set_status_pending
mrclary Sep 28, 2023
8919baf
Restrict channel to conda-forge on install
mrclary Sep 28, 2023
f19d4c5
Search conda-forge instead of anaconda's main channel.
mrclary Sep 28, 2023
a89ac0c
Refactor the resetting of WorkerUpdates attributes.
mrclary Sep 28, 2023
b750b79
Move the try...except clauses in WorkerUpdates.start to WorkerUpdates…
mrclary Sep 28, 2023
630c9c1
pep8
mrclary Sep 28, 2023
c30f566
Refactor _check_updates_ready for better clarity in the flow control.
mrclary Sep 29, 2023
6c58869
Add header to confirm_installation message box
mrclary Sep 29, 2023
a81d5f0
Update download message.
mrclary Sep 29, 2023
980b4e3
Use conda-forge channeldata.json instead of conda search.
mrclary Sep 29, 2023
9a44cfb
Change cancel download message.
mrclary Sep 29, 2023
583254c
Use conda-forge channeldata.json to get releases for conda runtime en…
mrclary Sep 29, 2023
c7b7a51
Simplify WorkerUpdates.
mrclary Sep 29, 2023
c872d69
Use __version__ instead of WorkerUpdates.version
mrclary Sep 30, 2023
93c7d77
Refactor installer UIs to install.py.
mrclary Sep 30, 2023
6ef4b68
Create user preference to determine whether to consider unstable rele…
mrclary Sep 30, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use x86_64 for Windows machine architecture. Fix this later
  • Loading branch information
mrclary committed Sep 29, 2023
commit c7c4e9943c2bd54e0321dad4e198ad44adac1fac
2 changes: 1 addition & 1 deletion spyder/workers/updates.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,7 +213,7 @@ def _download_installer(self):
plat, ext = 'macOS', 'pkg'
if sys.platform.startswith('linux'):
plat, ext = 'Linux', 'sh'
mach = platform.machine()
mach = platform.machine().lower().replace("amd64", "x86_64")
fname = f'Spyder-{self.latest_release_version}-{plat}-{mach}.{ext}'

url = ('https://github.com/spyder-ide/spyder/releases/latest/'
Expand Down