-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Define Switcher Plugin public API + fix switcher position bug #20837
PR: Define Switcher Plugin public API + fix switcher position bug #20837
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @angelasofiaremolinagutierrez! I left some minor suggestions for you and a couple of questions, the rest looks pretty good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work here @angelasofiaremolinagutierrez ! Left some comments regarding methods that could be part of the plugin (open_switcher
and open_symbolfinder
), some info about the on_close
method that the plugin or container can implement, and an attribute that seems like could be removed (self._modes
at the plugin on_initialize
).
If you have any question about the above or something else lets us know!
Rename close method to on_close and add open_switcher and open_symbolfinder to the public API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @angelasofiaremolinagutierrez !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too, thanks @angelasofiaremolinagutierrez!
Description of Changes
spyder/plugins/switcher/
tospyder/plugins/editor/utils/
and rename it frommanager.py
toswitcher_manager.py
Issue(s) Resolved
Continue PR #20714
Necessary to solve #3860
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @angelasofiaremolinagutierrez