Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move CONF usage for bookmarks logic and use SpyderConfiguratorAccessor class in Editor widgets (Editor) #20825

Merged
merged 5 commits into from
Apr 20, 2023
Merged

PR: Move CONF usage for bookmarks logic and use SpyderConfiguratorAccessor class in Editor widgets (Editor) #20825

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2026171
Editor: Move CONF usage for bookmarks logic and use SpyderConfigurato…
dalthviz Apr 12, 2023
45eaf5d
Merge branch 'master' into editor_conf
dalthviz Apr 17, 2023
2dc4a58
Apply suggestions from code review
dalthviz Apr 20, 2023
d6c35b8
Change bookmark function name to 'update_bookmarks'
dalthviz Apr 20, 2023
47080c6
Merge branch 'editor_conf' of https://github.com/dalthviz/spyder into…
dalthviz Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
  • Loading branch information
@dalthviz @ccordoba12
dalthviz and ccordoba12 authored Apr 20, 2023
commit 2dc4a5867262883cd3dd3b435552c3a074307cbf
4 changes: 3 additions & 1 deletion spyder/plugins/editor/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1680,7 +1680,9 @@ def register_editorstack(self, editorstack):
for method, setting in settings:
getattr(editorstack, method)(self.get_option(setting))

editorstack.set_help_enabled(self.get_conf('help', 'connect/editor'))
editorstack.set_help_enabled(
self.get_conf('connect/editor', section='help')
)

hover_hints = self.get_conf(
('provider_configuration', 'lsp', 'values', 'enable_hover_hints'),
Expand Down
4 changes: 2 additions & 2 deletions spyder/plugins/editor/widgets/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@


class TextEditBaseWidget(
QPlainTextEdit, BaseEditMixin, SpyderConfigurationAccessor
):
QPlainTextEdit, BaseEditMixin, SpyderConfigurationAccessor
):
"""Text edit base widget"""
BRACE_MATCHING_SCOPE = ('sof', 'eof')
focus_in = Signal()
Expand Down
5 changes: 3 additions & 2 deletions spyder/plugins/editor/widgets/editor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
QListWidgetItem, QSizePolicy, QToolBar)

# Local imports
from spyder.api.config.mixins import SpyderConfigurationAccessor
from spyder.api.panel import Panel
from spyder.config.base import _, running_under_pytest
from spyder.config.gui import is_dark_interface
from spyder.api.config.mixins import SpyderConfigurationAccessor
from spyder.config.utils import (get_edit_filetypes, get_edit_filters,
get_filter, is_kde_desktop, is_anaconda)
from spyder.plugins.editor.utils.autosave import AutosaveForStack
Expand Down Expand Up @@ -100,7 +100,8 @@ def __init__(self, parent, stack_history, tabs):
self.config_shortcut(
lambda: self.select_row(1),
context='Editor',
name='Go to next file', parent=self
name='Go to next file',
parent=self
)

def load_data(self):
Expand Down