Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add --no-sandbox argument for QtApplication #20482

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

tlunet
Copy link
Contributor

@tlunet tlunet commented Feb 5, 2023

Description of Changes

Add --no-sandbox argument when instantiating QtApplication object, in order to avoid a bug linked to Ubuntu 22.04 (see https://discourse.slicer.org/t/extensions-not-showing-anything/23432/5 and https://doc.qt.io/qt-6/qtwebengine-platform-notes.html)

Note sure if this is needed in manager.py tho, put it here just for consistency.

Issue(s) Resolved

Fixes #20358

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: tlunet

@jitseniesen
Copy link
Member

I can confirm that this fixes the issue for me when running from source using python bootstrap.py.

Good work!

@tlunet
Copy link
Contributor Author

tlunet commented Feb 6, 2023

Thanks @jitseniesen, you did pointed me already in the good direction with your comment on PyQt 😃

Btw, should I make this parameter conditional to Linux so the MacOS test can pass ?

@jitseniesen
Copy link
Member

@tlunet Nice, to me it indicated that it was too hard a problem for me to solve, so I gave up!

Btw, should I make this parameter conditional to Linux so the MacOS test can pass ?

I don't see evidence that the MacOS failure has anything to do with your change; in fact, it's not clear at all why the test timed out. I am running it again, see whether it makes a difference.

Say hello to Daniel Ruprecht (I saw SDC and TUHH on your GitHub profile, so I assume you work with him).

@jitseniesen
Copy link
Member

OK, looks like there is an issue with spyder/plugins/ipythonconsole/tests/test_ipythonconsole.py on Mac. I don't know what to do, it probably needs somebody with more experience and/or access to a Mac.

@tlunet
Copy link
Contributor Author

tlunet commented Feb 6, 2023

Seems not linked to this PR, if I'm not mistaken ? See : https://github.com/spyder-ide/spyder/actions/runs/4088046116/jobs/7049275728

@ccordoba12 ccordoba12 added this to the v5.4.3 milestone Feb 6, 2023
@ccordoba12 ccordoba12 changed the title PR: add --no-sandbox argument for QtApplication PR: Add --no-sandbox argument for QtApplication Feb 6, 2023
@ccordoba12
Copy link
Member

Seems not linked to this PR, if I'm not mistaken ?

Yeah, I don't think it is. I restarted that job to see if it passes a second time.

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tlunet for your help digging this problem and proposing a solution for it!

@ccordoba12 ccordoba12 merged commit b599f42 into spyder-ide:5.x Feb 7, 2023
ccordoba12 added a commit that referenced this pull request Feb 7, 2023
@matiast1905
Copy link

I had this issue and the PR solved it.

Spyder version:

  • Spyder version: 5.4.2 (conda)
  • Python version: 3.11.0 64-bit
  • Qt version: 5.15.6
  • PyQt5 version: 5.15.7
  • Operating System: Linux 6.0.12-76060006-generic

Linux Pop!_OS 22.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants