-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add --no-sandbox
argument for QtApplication
#20482
Conversation
I can confirm that this fixes the issue for me when running from source using Good work! |
Thanks @jitseniesen, you did pointed me already in the good direction with your comment on PyQt 😃 Btw, should I make this parameter conditional to Linux so the MacOS test can pass ? |
@tlunet Nice, to me it indicated that it was too hard a problem for me to solve, so I gave up!
I don't see evidence that the MacOS failure has anything to do with your change; in fact, it's not clear at all why the test timed out. I am running it again, see whether it makes a difference. Say hello to Daniel Ruprecht (I saw SDC and TUHH on your GitHub profile, so I assume you work with him). |
OK, looks like there is an issue with |
Seems not linked to this PR, if I'm not mistaken ? See : https://github.com/spyder-ide/spyder/actions/runs/4088046116/jobs/7049275728 |
--no-sandbox
argument for QtApplication--no-sandbox
argument for QtApplication
Yeah, I don't think it is. I restarted that job to see if it passes a second time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tlunet for your help digging this problem and proposing a solution for it!
I had this issue and the PR solved it. Spyder version:
Linux Pop!_OS 22.04 LTS |
Description of Changes
Add
--no-sandbox
argument when instantiating QtApplication object, in order to avoid a bug linked to Ubuntu 22.04 (see https://discourse.slicer.org/t/extensions-not-showing-anything/23432/5 and https://doc.qt.io/qt-6/qtwebengine-platform-notes.html)Note sure if this is needed in
manager.py
tho, put it here just for consistency.Issue(s) Resolved
Fixes #20358
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: tlunet