-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Add menu to use specific environment interpreter for a new console instance #20421
PR: Add menu to use specific environment interpreter for a new console instance #20421
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Hi @dalthviz |
@jsbautista, perhaps I don't remember a lot of the discussion in spyder-ide/ux-improvements#10, but would it be better to remove "Console X" from the tab text? It seems to me to be unnecessary. Nevertheless, the work you've done on this looks real good to me, thanks! |
That needs additional discussion because it doesn't seem so simple to me (I'm not going to describe my reasoning here to not derail @jsbautista's work). So @mrclary, could you post your comment on spyder-ide/ux-improvements#10 so we can keep talking about it there? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista for the work here! Left an initial review regarding the kwargs passed to the methods (which maybe could be simplified to just use one) and some other questions regarding possible code refactoring.
If you have any question let me know!
Co-authored-by: Daniel Althviz Moré <d.althviz10@uniandes.edu.co>
Co-authored-by: Daniel Althviz Moré <d.althviz10@uniandes.edu.co>
@ccordoba12 @mrclary could you give this a check? I think is ready for a review. Although the scope of this is not to do changes in the way the consoles are named, I added some changes to the implementation here to follow the way special consoles naming work (adding instead of I think the changes regarding how in general the names of the consoles work should be done in a different PR since the main scope of this is to add a new menu from where you can launch a new console from a specific environment. Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jsbautista and @dalthviz for your great work here! I left some small suggestions and comments for you, the rest looks good to me.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any additional comments beyond @ccordoba12's comments. Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now, thanks @jsbautista and @dalthviz!
@dalthviz, I'll leave the merge to you in case you want to do a squash-merge.
Description of Changes
Add menu to launch a console using the intepreter of a specific environments:
Console
for consoles requested to be created using a specific env interpreter from the new submenu (following the current approach the special consoles use):Issue(s) Resolved
Part of spyder-ide/ux-improvements#10
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct:
@jsbautista