Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Update PyQt requirement to 5.15 #16409

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Sep 12, 2021

Description of Changes

  • This is finally the time to do it because we're going to have PyQt 5.15 packages available in conda-forge, thanks to @andfoy's work.
  • I expect this to take some time because our test suite is big.

Issue(s) Resolved

Fixes #17197
Fixes #17085
Fixes #17083
Fixes #17060
Fixes #12829

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @ccordoba12

@ccordoba12 ccordoba12 added this to the v5.2.0 milestone Sep 12, 2021
@ccordoba12 ccordoba12 self-assigned this Sep 12, 2021
@rear1019
Copy link
Contributor

check_qt() in spyder/requirements.py must be updated as well.

@juliangilbey
Copy link
Contributor

Just looking at the changes, I wonder whether you could include more recent Pythons in the testing (the current version in the tests is 3.7)? The current Python version is 3.10, while 3.8 was released over two years ago.

@pep8speaks
Copy link

pep8speaks commented Jan 27, 2022

Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-03-17 17:20:03 UTC

@ccordoba12
Copy link
Member Author

@dalthviz, please rebase to get the fixes for our tests I pushed last weekend. With them, you can check if the fast tests actually fisnish.

@dalthviz dalthviz force-pushed the update-pyqt branch 2 times, most recently from 558ed8f to 5f2e2e3 Compare February 3, 2022 16:58
@ccordoba12
Copy link
Member Author

@dalthviz, I skipped spyder/plugins/onlinehelp/tests/test_pydocgui.py::test_get_pydoc in PR #17288 because it was failing too much.

Since you fixed it here, please renable it after a rebase.

@dalthviz dalthviz self-assigned this Feb 8, 2022
@dalthviz dalthviz force-pushed the update-pyqt branch 3 times, most recently from fc78d64 to 5a04282 Compare March 15, 2022 16:27
@dalthviz dalthviz changed the title [WIP] PR: Update PyQt requirement to 5.15 PR: Update PyQt requirement to 5.15 Mar 15, 2022
@dalthviz dalthviz marked this pull request as ready for review March 15, 2022 18:15
Copy link
Member Author

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @dalthviz for your hard work on this!

It looks pretty good to me, except for the minor comments I left for you below.

Copy link
Member Author

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last minor nitpick @dalthviz, then this should be finally ready!!

@ccordoba12
Copy link
Member Author

Thanks again @dalthviz! Great work here!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants