-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Update PyQt requirement to 5.15 #16409
Conversation
|
1aa2637
to
9fc7b1f
Compare
9fc7b1f
to
02549f7
Compare
70c145e
to
55ee33b
Compare
Just looking at the changes, I wonder whether you could include more recent Pythons in the testing (the current version in the tests is 3.7)? The current Python version is 3.10, while 3.8 was released over two years ago. |
55ee33b
to
086d6f8
Compare
Hello @ccordoba12! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2022-03-17 17:20:03 UTC |
@dalthviz, please rebase to get the fixes for our tests I pushed last weekend. With them, you can check if the fast tests actually fisnish. |
558ed8f
to
5f2e2e3
Compare
fc78d64
to
5a04282
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @dalthviz for your hard work on this!
It looks pretty good to me, except for the minor comments I left for you below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last minor nitpick @dalthviz, then this should be finally ready!!
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
…nsole.py::test_connection_to_external_kernel
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
Thanks again @dalthviz! Great work here!! |
Description of Changes
Issue(s) Resolved
Fixes #17197
Fixes #17085
Fixes #17083
Fixes #17060
Fixes #12829
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12