Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to verify that importing .mat files is working #4076

Closed
jim-gardiner opened this issue Jan 30, 2017 · 9 comments
Closed

Add tests to verify that importing .mat files is working #4076

jim-gardiner opened this issue Jan 30, 2017 · 9 comments

Comments

@jim-gardiner
Copy link

Import of .mat file after upgrade to v3.1.2

files saved with 3.1.2 can be opened and saved in 3.1.0.

image

@goanpeca
Copy link
Member

@spyder-ide/junior-developers any of you have a working matlab to work on this?

@andfoy
Copy link
Member

andfoy commented Jan 30, 2017

I do!

@goanpeca
Copy link
Member

the its yours :-p

@andfoy andfoy self-assigned this Jan 30, 2017
@andfoy
Copy link
Member

andfoy commented Jan 30, 2017

@jim-gardiner Was the .mat file saved in MATLAB?

@jim-gardiner
Copy link
Author

jim-gardiner commented Jan 30, 2017 via email

@goanpeca goanpeca added this to the v3.1.3 milestone Jan 30, 2017
@ccordoba12 ccordoba12 modified the milestones: v3.2, v3.1.3, v3.1.4 Jan 31, 2017
@ccordoba12 ccordoba12 changed the title import of .mat files Import of .mat files is failing Jan 31, 2017
@jim-gardiner
Copy link
Author

an update,

a full conda update --all seems to have fixed the problem.

sorry for any confusion.

@ccordoba12 ccordoba12 modified the milestone: v3.1.4 Jan 31, 2017
@ccordoba12
Copy link
Member

@andfoy, let's take the opportunity to add tests to verify that this is working.

If I'm not mistaken, I think this requires the scipy package to be installed.

@ccordoba12 ccordoba12 modified the milestones: v3.2, v3.1.4 Jan 31, 2017
@ccordoba12 ccordoba12 changed the title Import of .mat files is failing Add tests to verify that Importing .mat is working Jan 31, 2017
@ccordoba12 ccordoba12 changed the title Add tests to verify that Importing .mat is working Add tests to verify that Importing .mat files is working Jan 31, 2017
@andfoy
Copy link
Member

andfoy commented Jan 31, 2017

@ccordoba12 Yes, it needs the scipy.io package

@ccordoba12
Copy link
Member

Ok, please proceed to make the tests then :-)

@ccordoba12 ccordoba12 changed the title Add tests to verify that Importing .mat files is working Add tests to verify that importing .mat files is working Feb 4, 2017
ccordoba12 added a commit that referenced this issue Feb 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants