Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyntaxErrors with Python 3.2 #2239

Closed
Arfrever opened this issue Mar 13, 2015 · 11 comments
Closed

SyntaxErrors with Python 3.2 #2239

Arfrever opened this issue Mar 13, 2015 · 11 comments

Comments

@Arfrever
Copy link

$ python3.2 -m compileall -fq spyderlib spyderplugins
*** Error compiling 'spyderlib/plugins/layoutdialog.py'...
  File "spyderlib/plugins/layoutdialog.py", line 155
    if to_text_string(text) == u'':
                                 ^
SyntaxError: invalid syntax

*** Error compiling 'spyderlib/pygments_patch.py'...
  File "spyderlib/pygments_patch.py", line 72
    yield pos, Text, u'\n'
                         ^
SyntaxError: invalid syntax

*** Error compiling 'spyderplugins/widgets/condapackagesgui.py'...
  File "spyderplugins/widgets/condapackagesgui.py", line 53
    def sort_versions(versions=(), reverse=False, sep=u'.'):
                                                         ^
SyntaxError: invalid syntax

@ccordoba12
Copy link
Member

Are these all errors you found?

@ccordoba12 ccordoba12 added this to the v2.3.4 milestone Mar 13, 2015
@blink1073
Copy link
Contributor

The unicode literal was added in 3.3: https://www.python.org/dev/peps/pep-0414/

@Nodd
Copy link
Contributor

Nodd commented Mar 13, 2015

The first one should be if not to_text_string(text):, so this is an easy fix !

@ccordoba12
Copy link
Member

I'll fix the error in pygments_patch for 2.3.4. The others were introduced by @goanpeca.

But I think we should just drop support for 3.2 for 2.4 because very few people are running Spyder there (that I know of).

@spyder-ide/core-developers, what do you think?

@blink1073
Copy link
Contributor

I say dump it! Matplotlib dropped 3.2 support recently. I've been trying to get scikit-image to drop it...

@goanpeca
Copy link
Member

I am 👍 on dumping it!

@goanpeca
Copy link
Member

But I will fix it nevertheless. The package manager has some issues right now besides that, and will get fixed soon. I am normally only testin py2.7 and py3.4 on linux and 3.3 on win (what i can get install with anaconda)

@stonebig
Copy link
Contributor

anaconda can't get install python3.4 on win ?

@goanpeca
Copy link
Member

I rephrase... I normally use: Lin (2.7, 3.4) and on win (2.7, 3.3, 3.4)

@ccordoba12
Copy link
Member

@goanpeca, don't worry about it. I'm going to follow @blink1073 advice and drop support for Python 3.2 (and 2.6 too) in our next major release. Since your contributions are planned for that release, you don't need to fix those u' cases.

It doesn't make sense to try to support versions which we are not able to test easily, but thanks @Arfrever for letting us know about the problem in pygments_patch

@Nodd
Copy link
Contributor

Nodd commented Mar 16, 2015

👍 for dropping 2.6 and 3.2. It is coherent with the compatibility with Qt5, new-types signals... Spyder is getting some fresh air !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants