Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Move version out of init file. #55

Merged
merged 2 commits into from
May 5, 2017

Conversation

rlaverde
Copy link
Member

Fixes #54

@ccordoba12 I move __version__ to _version.py as you suggested

But that wasn't enough, when doing: from spyder_notebook._version import __version__ the module is imported and the __init__.py is exectuted anyway

I copied a modified get_version() function from other spyder plugins, is that ok?

@rlaverde rlaverde added this to the v0.1 milestone Apr 26, 2017
@rlaverde rlaverde self-assigned this Apr 26, 2017
@rlaverde rlaverde requested review from ccordoba12 and dalthviz April 26, 2017 12:31
@ccordoba12
Copy link
Member

@rlaverde, please rebase in top of master to fix the errors in Circle.

@rlaverde rlaverde force-pushed the version-out-init branch from 652b976 to ba406d1 Compare May 5, 2017 16:10
@@ -0,0 +1,2 @@
VERSION_INFO = (0, 1, 0, 'dev0')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rlaverde can you add a docstring here? Also, thank you for your help!

@ccordoba12 ccordoba12 changed the title PR: Move version out of __init__ file. PR: Move version out of init file. May 5, 2017
@ccordoba12 ccordoba12 merged commit 82a9cd6 into spyder-ide:master May 5, 2017
@rlaverde rlaverde deleted the version-out-init branch May 5, 2017 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants