Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Fixes to work with Notebook 4.3+ #44

Merged
merged 4 commits into from
Mar 22, 2017
Merged

PR: Fixes to work with Notebook 4.3+ #44

merged 4 commits into from
Mar 22, 2017

Conversation

ccordoba12
Copy link
Member

@ccordoba12 ccordoba12 commented Mar 12, 2017 •
edited
Loading

Fixes #12.

Without this we can't run our tests.

@ccordoba12 ccordoba12 added this to the v0.1 milestone Mar 12, 2017
@ccordoba12 ccordoba12 changed the title Fixes to work with Notebook 4.3+ PR: [WIP] Fixes to work with Notebook 4.3+ Mar 12, 2017
@ccordoba12
Copy link
Member Author

Unfortunately this is not ready yet.

@ccordoba12 ccordoba12 force-pushed the nb-4.3 branch 2 times, most recently from 0aa9b33 to 3c8b187 Compare March 22, 2017 16:07
@ccordoba12 ccordoba12 changed the title PR: [WIP] Fixes to work with Notebook 4.3+ PR: Fixes to work with Notebook 4.3+ Mar 22, 2017
@ccordoba12
Copy link
Member Author

This is ready now!! Yay :-)

@ccordoba12 ccordoba12 merged commit 08bad92 into spyder-ide:master Mar 22, 2017
@ccordoba12 ccordoba12 deleted the nb-4.3 branch March 22, 2017 16:32
@ccordoba12
Copy link
Member Author

This was fixed thanks to jupyter/help#151

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1
Development

Successfully merging this pull request may close these issues.
1 participant
@ccordoba12