PR: Add CircleCI basic integration #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Jan 16, 2017
| #- $CMD_TEST_PYTHON setup.py develop; | ||
|
|
||
| # Environment for lint checks | ||
| - conda create -n lint ciocheck python=3.5 -c conda-forge -q |
There was a problem hiding this comment.
Please change the name of the environment to test because once this is in place we'll start adding pytest's :-)
Also, please install ciocheck from the spyder-ide channel to avoid mixing compiled dependencies between defaults and conda-forge. I did the same for Spyder.
|
I am not using the astropy helpers. They are useless with circle ci |
|
@ccordoba12 this is ready. This puts the infrastructure but no checks are included so far. The next PR will fix this. |
|
Ok, thanks a lot for working on this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
For now only checks pep8 (but it does not enforce it), another PR will fix all formatting changes.