PR: Handle I/O errors when doing "Save As" #250

jitseniesen · 2020-03-11T14:28:26Z

This PR catches errors in .save_as() and displays a error dialog to the user with the error message.

Fixes #150

Also add a test.

jitseniesen · 2020-03-13T08:49:35Z

Rebasing to get new test environment ...

codecov-io · 2020-03-13T09:28:46Z

Codecov Report

Merging #250 into master will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted Files	Coverage Δ
spyder_notebook/notebookplugin.py	`72.64% <66.66%> (-0.09%)`	⬇️

jitseniesen added the v0.2.3 label Mar 11, 2020

jitseniesen self-assigned this Mar 11, 2020

Plugin: Handle I/O errors when doing "Save As"

078d48b

Also add a test.

jitseniesen force-pushed the fix-saveas branch from 59efa80 to 078d48b Compare March 13, 2020 08:49

Tests: Python 2 compatibility fix

a5d8100

jitseniesen force-pushed the fix-saveas branch from e595547 to a5d8100 Compare March 13, 2020 09:34

jitseniesen added 3 commits March 13, 2020 09:44

CI: Shorten CodeCov's comments on GitHub

a450f12

CI: Relax coverage requirements

a4426d3

CI: Rename .codecov.yml to codecov.yml

903bf6b

See https://docs.codecov.io/docs/codecov-yaml#section-can-i-name-the-file-codecov-yml

jitseniesen merged commit c94f4b7 into spyder-ide:master Mar 13, 2020

jitseniesen deleted the fix-saveas branch March 13, 2020 12:47