Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update README.md, CONTRIBUTING.md, screenshot and add RELEASE.md #62

Merged
merged 2 commits into from
May 23, 2022
Merged

PR: Update README.md, CONTRIBUTING.md, screenshot and add RELEASE.md #62

merged 2 commits into from
May 23, 2022

Conversation

dalthviz
Copy link
Member

Part of #59

@dalthviz dalthviz added this to the v0.3.0 milestone May 19, 2022
@dalthviz dalthviz self-assigned this May 19, 2022
@dalthviz dalthviz changed the title PR: Update README.md, CONTRIBUTING.md, screenshot and add RELEASE.md PR: Update README.md, CONTRIBUTING.md, screenshot and add RELEASE.md May 19, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022 •
edited
Loading

Codecov Report

Merging #62 (c8e620d) into master (17418c5) will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted Files Coverage Δ
...der_line_profiler/example/profiling_test_script.py 0.00% <0.00%> (ø)

ccordoba12
ccordoba12 reviewed May 19, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @dalthviz! I left some minor suggestions/comments for you.

Looking at the screenshot: are we using here colors that come from SpyderPalette? If not, I think we should to make things uniform with the rest of Spyder.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
RELEASE.md Outdated Show resolved Hide resolved
RELEASE.md Show resolved Hide resolved
RELEASE.md
* Build source distribution and wheel

```bash
python -bb -X dev -W error -m build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this command won't work because we're not using pyproject.toml here. Did you check it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copy-pasted from qtpy 😅 although checking seems like the command works:

imagen

@dalthviz @ccordoba12
Apply suggestions from code review
857c25d 
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
@dalthviz
Copy link
Member Author

dalthviz commented May 23, 2022 •
edited
Loading

Looking at the screenshot: are we using here colors that come from SpyderPalette? If not, I think we should to make things uniform with the rest of Spyder.

I don't think so (that we are currently using the SpyderPalette). I think #50 covers that. Maybe that could be something to do after the 0.3.0 release?

@ccordoba12
Copy link
Member

Maybe that could be something to do after the 0.3.0 release?

Ok, no problem. Let's leave that for later.

ccordoba12
ccordoba12 approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for your work on this!

@ccordoba12 ccordoba12 merged commit 3b2bfb8 into spyder-ide:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

@jitseniesen jitseniesen Awaiting requested review from jitseniesen

Assignees

@dalthviz dalthviz

Labels
type:task
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dalthviz @codecov-commenter @ccordoba12