Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add default config and change plugin icon #61

Merged
merged 2 commits into from
May 19, 2022
Merged

PR: Add default config and change plugin icon #61

merged 2 commits into from
May 19, 2022

Conversation

dalthviz
Copy link
Member

Part of #59

Icon preview:

lineprof

imagen

@dalthviz dalthviz added this to the v0.3.0 milestone May 18, 2022
@dalthviz dalthviz self-assigned this May 18, 2022
ccordoba12
ccordoba12 reviewed May 19, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for this! I left a minor comment for you.

setup.py Outdated Show resolved Hide resolved
jitseniesen
jitseniesen reviewed May 19, 2022
View reviewed changes
Copy link
Member

@jitseniesen jitseniesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@dalthviz dalthviz requested a review from ccordoba12 May 19, 2022 14:47
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022 •
edited
Loading

Codecov Report

Merging #61 (434770f) into master (ec60a54) will decrease coverage by 0.69%.
The diff coverage is 0.00%.

Impacted Files Coverage Δ
spyder_line_profiler/spyder/config.py 0.00% <0.00%> (ø)
spyder_line_profiler/spyder/plugin.py 0.00% <0.00%> (ø)

ccordoba12
ccordoba12 approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 7a570fe into spyder-ide:master May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jitseniesen jitseniesen jitseniesen left review comments

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
type:enhancement
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dalthviz @codecov-commenter @ccordoba12 @jitseniesen