Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gallery section regressions due to Bootstrap 5 migration #28

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

conradolandia
Copy link
Contributor

Added a couple classes to handle this case, omited when we did the migration to Bootstrap 5.

@CAM-Gerlach CAM-Gerlach self-requested a review February 21, 2024 00:54
@CAM-Gerlach CAM-Gerlach added the bug Something isn't working label Feb 21, 2024
@CAM-Gerlach CAM-Gerlach changed the title Fix gallery regression Fix gallery regressions when migrating to Bootstrap 5 Feb 21, 2024
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing the appearance and functionality of both 3- and 4-card gallery layouts, at a range of widths, as well as a smoke test of the rest of the page, everything looks good! Thanks @conradolandia !

@CAM-Gerlach CAM-Gerlach changed the title Fix gallery regressions when migrating to Bootstrap 5 Fix gallery regressions due to Bootstrap 5 migration Feb 21, 2024
@CAM-Gerlach CAM-Gerlach changed the title Fix gallery regressions due to Bootstrap 5 migration Fix gallery section regressions due to Bootstrap 5 migration Feb 21, 2024
@CAM-Gerlach CAM-Gerlach merged commit 1be4fd4 into spyder-ide:master Feb 21, 2024
3 checks passed
@CAM-Gerlach CAM-Gerlach added this to the v3.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants