Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Build Error Fixes #3004

Merged
merged 5 commits into from
Jan 15, 2025
Merged

CI Build Error Fixes #3004

merged 5 commits into from
Jan 15, 2025

Conversation

james-hooper-spryker
Copy link
Collaborator

PR Description

Some pages had 404s / 403s causing errors in CI build, changes for these have been applied

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/spryker-docs/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

Some pages had 404s / 403s causing errors in CI build, changes for these have been applied
@james-hooper-spryker james-hooper-spryker added the TW review needed PR needs Technical writer's review label Dec 18, 2024
@andriitserkovnyi andriitserkovnyi merged commit d36960c into master Jan 15, 2025
3 checks passed
@andriitserkovnyi andriitserkovnyi deleted the CI-Build-Error-Fixes branch January 15, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TW review needed PR needs Technical writer's review
Development

Successfully merging this pull request may close these issues.

2 participants