Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tutorial-hello-world.md #3000

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

parasdaftary
Copy link

According other modules Plugin has Router folder for RouterProviderPlugin class instead of Provider folder. I would request to update this to Router folder to be consistent. I tested this and it worked fine.

PR Description

Add a meaningful description here that will let us know what you want to fix with this PR or what functionality you want to add.

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/spryker-docs/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

According other modules Plugin has Router folder for RouterProviderPlugin class instead Provider. I would request to update this Router folder to be consistent. I tested this and it worked fine.
@parasdaftary
Copy link
Author

If this pull request gets approved then it would require to change references in code sample in documentation for HelloWorld example to Router folder.

namespace Pyz\Yves\HelloWorld\Plugin\Provider - existing

namespace Pyz\Yves\HelloWorld\Plugin\Router - change request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant