Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-32215 IGs and Security doc. #2480

Merged

Conversation

ilyakubanov
Copy link
Contributor

@ilyakubanov ilyakubanov added tech review needed PR needs tech review in tech review PR is in review by a developer new PR contains a new document labels Jan 25, 2024
…v-agent-assist-in-merchant-portal

# Conflicts:
#	_includes/pbc/all/install-features/202403.0/marketplace/install-the-marketplace-merchant-feature.md
#	docs/pbc/all/merchant-management/202403.0/marketplace/install-and-upgrade/install-features/install-the-marketplace-merchant-feature.md
@abitskil abitskil added TW review needed PR needs Technical writer's review and removed tech review needed PR needs tech review labels Jan 26, 2024
abitskil
abitskil previously approved these changes Jan 26, 2024
@andriitserkovnyi andriitserkovnyi self-assigned this Jan 31, 2024
| group_name | ✓ | string | root_group | The name of the ACL group. |
| role_name | ✓ | string | root_role | The name of the ACL role. |

2. Add the following data to `data/import/local/full_EU.yml`:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite this step to specify what exactly we are doing by adding this data

}
```

Use the following example if you want to enable ACL Entity for the whole Application, for example, for the Merchant
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What do you mean by "using the example"?
  2. What do you mean by Application?
  3. What do I do if I don't want to enable the ACL Entity?


Make sure the following works correctly:

* The request doesn't succeed for users without permission.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which request?

Make sure the following works correctly:

* The request doesn't succeed for users without permission.
* The user can see only the allowed menu links.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which menu?

@@ -139,10 +139,10 @@ console transfer:generate

### 3) Set up the configuration

**src/Pyz/Zed/SecurityMerchantPortalGui/SecurityMerchantPortalGuiConfig.php**

Optional: For security reasons, we recommend enabling the security blocker feature that will block recurring attempts of resetting a password by setting `MERCHANT_PORTAL_SECURITY_BLOCKER_ENABLED` to `true;`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this whole step optional or only MERCHANT_PORTAL_SECURITY_BLOCKER_ENABLED?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole step.

Spryker requirements:

To start builder integration, check versions of Spryker packages:
Spryker requirements: To start builder integration, check versions of Spryker packages:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I need to update these packages only if I want to integrate the builder?

@@ -891,7 +892,7 @@ const globalSettings = {
```

9. Run commands from the root of the project:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specify what this command does

@andriitserkovnyi andriitserkovnyi merged commit ea08c6c into master Feb 2, 2024
14 checks passed
@andriitserkovnyi andriitserkovnyi deleted the feature/cc-32215/dev-agent-assist-in-merchant-portal branch February 2, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in tech review PR is in review by a developer new PR contains a new document TW review needed PR needs Technical writer's review
Development

Successfully merging this pull request may close these issues.

4 participants