Oryx contribution guide #2447
Merged
Oryx contribution guide #2447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 12, 2024 19:15
andriispryker
suggested changes
Jan 16, 2024
There was a problem hiding this comment.
Can we move it to the separate folder smth like "Contribute to Oryx" and also please add a reference to the documenation contribution guide as usially you also need to update a documentation as well https://docs.spryker.com/docs/scos/user/intro-to-spryker/contribute-to-the-documentation/contribute-to-the-documentation.html
andriispryker
suggested changes
Jan 16, 2024
| - If you’ve added code that should be tested, add tests. | ||
| - Ensure all GitHub actions required checks are passed. | ||
| - Provide a clear and concise description of your changes in the pull request description. | ||
|
|
There was a problem hiding this comment.
Add information about what happens next. After approving a pull request we will update a reporter with the next steps. Pull request can be rejected, approved or we may ask for some clarification or changes.
andriispryker
previously approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft of the Oryx contribution guide focused on Composable Storefront (so Fulfillment and other applications are totally missed here).
Code of Conduct and Contributor License Agreement are missing.