CC-31568: Extended the warehouse picking guide with the FA OAuth. #2325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakubanov
reviewed
Nov 20, 2023
.../pbc/all/install-features/202311.0/unified-commerce/install-the-warehouse-picking-feature.md
Outdated
Show resolved
Hide resolved
.../pbc/all/install-features/202311.0/unified-commerce/install-the-warehouse-picking-feature.md
Outdated
Show resolved
Hide resolved
.../pbc/all/install-features/202311.0/unified-commerce/install-the-warehouse-picking-feature.md
Outdated
Show resolved
Hide resolved
.../pbc/all/install-features/202311.0/unified-commerce/install-the-warehouse-picking-feature.md
Outdated
Show resolved
Hide resolved
.../pbc/all/install-features/202311.0/unified-commerce/install-the-warehouse-picking-feature.md
Show resolved
Hide resolved
ilyakubanov
previously approved these changes
Nov 20, 2023
.../pbc/all/install-features/202311.0/unified-commerce/install-the-warehouse-picking-feature.md
Outdated
Show resolved
Hide resolved
.../pbc/all/install-features/202311.0/unified-commerce/install-the-warehouse-picking-feature.md
Outdated
Show resolved
Hide resolved
ilyakubanov
previously approved these changes
Nov 20, 2023
| {% endinfo_block %} | ||
|
|
||
|
|
||
| ## 3) Set up configuration |
There was a problem hiding this comment.
I split this section into subsections. Please make sure the subsection titles are relevant
| | PLUGIN | SPECIFICATION | PREREQUISITES | NAMESPACE | | ||
| |--------------------------------------------------------------|----------------------------------------------------------------------------------------------------|---------------|--------------------------------------------------------------------------| | ||
| | AuthorizeResource | Registers the OAuth authorize resource. | | SprykerEco\Glue\AuthorizationPickingAppBackendApi\Plugin\GlueApplication | | ||
| | UserAuthCodeOauthRequestGrantTypeConfigurationProviderPlugin | Builds `OauthGrantTypeConfigurationTransfer` from the configuration of AuthorizationCode GrantType data. | | Spryker\Zed\OauthCodeFlow\Communication\Plugin\Oauth | |
There was a problem hiding this comment.
Are AuthorizationCode and GrantType separate code references?
There was a problem hiding this comment.
Only the AuthorizationCode.
| |-----------------------|--------|-----------------------------------|--------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------| | ||
| | username | string | some@user.com | The username of the Back Office user. | | ||
| | password | string | 349dldks239fj93498di | The password of the Back Office user. | | ||
| | response_type | string | code | Defines how the authorization server should respond to the client after the resource owner grants. | |
There was a problem hiding this comment.
Extended the sentence.
| | username | string | some@user.com | The username of the Back Office user. | | ||
| | password | string | 349dldks239fj93498di | The password of the Back Office user. | | ||
| | response_type | string | code | Defines how the authorization server should respond to the client after the resource owner grants. | | ||
| | client_id | string | the-client-identifier-of-your-app | Public identifier for the client application that is requesting access to a user's resources. | |
There was a problem hiding this comment.
Provide proper examples. See other parameters as well
Comment on lines
765
to
768
| | grant_type | string | authorization_code | Specifies the type of grant requested by the client. In this case, it's the Authorization Code Grant flow. | | ||
| | code | string | some-code | The authorization code provided by the OAuth server. | | ||
| | client_id | string | the-client-identifier-of-your-app | Public identifier for the client application that is requesting access to a user's resources. | | ||
| | code_verifier | string | some-random-string | A random string generated by the client in the Authorization Code Grant flow with PKCE. It's used to verify the identity of the client when exchanging the authorization code for an access token. | |
There was a problem hiding this comment.
Provide the actual examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Epic: https://spryker.atlassian.net/browse/CC-31691
Ticket: https://spryker.atlassian.net/browse/CC-31568