CC-31652 Introduced datasource.dependable and datasource.trigger services.
#2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRITS-Kh
suggested changes
Nov 6, 2023
...307.0/marketplace/ui-components-library/datasources/datasource-trigger/datasource-trigger.md
Outdated
Show resolved
Hide resolved
...307.0/marketplace/ui-components-library/datasources/datasource-trigger/datasource-trigger.md
Outdated
Show resolved
Hide resolved
FRITS-Kh
previously approved these changes
Nov 6, 2023
...-development/202307.0/marketplace/ui-components-library/datasources/datasource-dependable.md
Outdated
Show resolved
Hide resolved
| | - | - | | ||
| |type | A datasource type. | | ||
| |event | An event type triggered by element. | | ||
| |debounce | Delays the emission of values the next datasource (default is `300ms`). | |
There was a problem hiding this comment.
Can you clarify the description? Looks like something is missing
There was a problem hiding this comment.
What exactly? Description looks clear
There was a problem hiding this comment.
I don't get how the next datasource relates to the preceding part of the sentence
There was a problem hiding this comment.
datasource is an angular service and not exactly data source
There was a problem hiding this comment.
Still don't get it, but I'll try to guess:
Suggested change
| |debounce | Delays the emission of values the next datasource (default is `300ms`). | | |
| |debounce | Delays the emission of values of the next datasource (default is `300ms`). | |
|
|
||
| The main module lets you register any `datasource.trigger` by key using the `withEvents()` static method. It assigns the object of datasources to `DatasourceEventTypesToken` under the hood. | ||
|
|
||
| The `resolve()` method gets the trigger element using the `DatasourceTriggerElement` abstract class (token), finds a specific service from `DatasourceEventTypesToken` by `config.event` (from the argument) and returns observable with data (based on the data returned from trigger element) by `Datasource.resolve()`. |
There was a problem hiding this comment.
Split this into several sentences and try to remove the braces
There was a problem hiding this comment.
In this case context will be missed
|
|
||
| ## Interfaces | ||
|
|
||
| Interfaces for the Datasource Trigger configuration and types: |
There was a problem hiding this comment.
Interfaces and types for the Datasource Trigger configuration:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://spryker.atlassian.net/browse/CC-31652