Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch versions for Oryx reactivity docs #2225

Merged
merged 7 commits into from
Oct 9, 2023

Conversation

dunqan
Copy link
Contributor

@dunqan dunqan commented Oct 6, 2023

No description provided.

@dunqan dunqan force-pushed the docs/fix-reactivity-versions branch from 135589b to fd24120 Compare October 6, 2023 09:37

The following example shows the usage of the `computed` signal. `Computed` wraps an observable into a `signal` that automatically subscribes to the underlying observable and triggers updating the view. This means that component developers don't need to worry about how the reactive system works under the hood.
Oryx components are built in TypeScript, and we provide types everywhere to improve developer experience and avoid errors upfront. The original type of the assigned observable needs to be adjusted. It's impossible to resolve a correct type from the observable by using a decorator, which is why the `valueType` function is used to resolve the observed type.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please convert the second sentence into active voice. Make it clear as to who's supposed to adjust it.

dunqan and others added 4 commits October 9, 2023 09:45
…yker-docs into docs/fix-reactivity-versions

# Conflicts:
#	docs/scos/dev/front-end-development/202212.0/oryx/architecture/reactivity/reactive-components.md
@andriitserkovnyi andriitserkovnyi added the small changes PR contains small changes, like typo fixes label Oct 9, 2023
@andriitserkovnyi andriitserkovnyi merged commit 5f996eb into master Oct 9, 2023
@andriitserkovnyi andriitserkovnyi deleted the docs/fix-reactivity-versions branch October 9, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small changes PR contains small changes, like typo fixes
Development

Successfully merging this pull request may close these issues.

2 participants