Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBC-2693: Update vertex integration guide. #2152

Conversation

danielsantos-spryker
Copy link
Contributor

PR Description

  • Update Vertex integration guide.

Ticket: https://spryker.atlassian.net/browse/PBC-2693

TBD

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@danielsantos-spryker danielsantos-spryker added the do not merge PR is not ready for merge label Sep 7, 2023
danielsantos-spryker and others added 3 commits September 7, 2023 14:46
also removed the explicit list of modules, because Vertex App catalog already has it.
@danielsantos-spryker danielsantos-spryker changed the title [DRAFT]PBC-2693: Update vertex integration guide. PBC-2693: Update vertex integration guide. Sep 13, 2023
@danielsantos-spryker danielsantos-spryker removed the do not merge PR is not ready for merge label Sep 13, 2023
@danielsantos-spryker danielsantos-spryker marked this pull request as ready for review September 13, 2023 09:56
Copy link
Collaborator

@matweew matweew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that 202307.0 is correct path of this page, because it's new functionality and will appear only in the next release.

So even having the page already published here https://docs.spryker.com/docs/pbc/all/tax-management/202307.0/vertex/install-vertex.html we need to move it to next version.

@matweew matweew added the TW review needed PR needs Technical writer's review label Sep 13, 2023
@danielsantos-spryker
Copy link
Contributor Author

I don't think that 202307.0 is correct path of this page, because it's new functionality and will appear only in the next release.

So even having the page already published here https://docs.spryker.com/docs/pbc/all/tax-management/202307.0/vertex/install-vertex.html we need to move it to next version.

@lenadoc what do you think about this?


## Integrate the Vertex app
[image here]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lenadoc please add it this picture instead of [image here]

matweew
matweew previously approved these changes Sep 19, 2023
@lenadoc lenadoc added the updated PR contains meaningful changes to some document label Sep 20, 2023
@lenadoc
Copy link
Contributor

lenadoc commented Sep 20, 2023

I don't think that 202307.0 is correct path of this page, because it's new functionality and will appear only in the next release.
So even having the page already published here https://docs.spryker.com/docs/pbc/all/tax-management/202307.0/vertex/install-vertex.html we need to move it to next version.

@lenadoc what do you think about this?

I totally agree. I've moved Vertex to the new version and added redirects from the current version to the new one for Vertex-related docs

@lenadoc lenadoc merged commit b65235b into master Sep 20, 2023
@lenadoc lenadoc deleted the feature/pbc-2681/pbc-2693-res-update-and-publish-the-documentation branch September 20, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TW review needed PR needs Technical writer's review updated PR contains meaningful changes to some document
Development

Successfully merging this pull request may close these issues.

4 participants