Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-26541 Adjusted IGs according changes related to code api conventions refactoring #2118

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

ievgen-malykhin
Copy link
Contributor

PR Description

Ticket: https://spryker.atlassian.net/browse/CC-30355

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@ievgen-malykhin ievgen-malykhin added the 202400 PR contains document for the upcoming release 202400 label Aug 25, 2023
@ievgen-malykhin ievgen-malykhin requested a review from a team as a code owner August 25, 2023 16:18
dmiseev
dmiseev previously approved these changes Sep 5, 2023
@dmiseev dmiseev added the TW review needed PR needs Technical writer's review label Sep 5, 2023
- The correct amount is displayed per sales order item.

Make sure the following:
* Abstract products that have packaging units available don’t have `add_to_cart_sku` field at Elasticsearch document.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Elasticsearch document" seems wrong here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you specify please what exactly is wrong?
We use ElasticSearch as a search engine.
I checked the case when the product has no packaging units: there is an add_to_cart_sku field in the elastic search document. But the product which has packaging units has no such field. That's what is mentioned here.

@lenadoc lenadoc added the updated PR contains meaningful changes to some document label Sep 13, 2023
@lenadoc lenadoc merged commit 8cac886 into master Sep 13, 2023
@lenadoc lenadoc deleted the feature/cc-26541/dev-shipment-types-sapi-refactor branch September 13, 2023 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
202400 PR contains document for the upcoming release 202400 TW review needed PR needs Technical writer's review updated PR contains meaningful changes to some document
Development

Successfully merging this pull request may close these issues.

3 participants