Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install the Service Points feature #2077

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Install the Service Points feature #2077

merged 8 commits into from
Aug 14, 2023

Conversation

romanhavrylko
Copy link
Contributor

@romanhavrylko romanhavrylko commented Aug 8, 2023 •
edited
Loading

PR Description

Epic: https://spryker.atlassian.net/browse/CC-26551
Ticket: https://spryker.atlassian.net/browse/CC-29983

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@romanhavrylko romanhavrylko added tech review needed PR needs tech review updated PR contains meaningful changes to some document labels Aug 8, 2023
@romanhavrylko romanhavrylko requested a review from a team as a code owner August 8, 2023 08:20
abitskil
abitskil reviewed Aug 9, 2023
View reviewed changes
Copy link
Contributor

@abitskil abitskil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to extend the list of modules from the "Make sure that the following modules have been installed:" section.

@VadymSachenko VadymSachenko added ready for merge The PR can be merged and removed tech review needed PR needs tech review labels Aug 14, 2023
@VadymSachenko VadymSachenko merged commit 0d2b9f1 into master Aug 14, 2023
@VadymSachenko VadymSachenko deleted the feature/cc-26551/dev-service-points-and-address-sapi branch August 14, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexSlawinski AlexSlawinski AlexSlawinski approved these changes

@VadymSachenko VadymSachenko VadymSachenko approved these changes

@abitskil abitskil abitskil approved these changes

Assignees
No one assigned
Labels
ready for merge The PR can be merged updated PR contains meaningful changes to some document
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romanhavrylko @abitskil @VadymSachenko @AlexSlawinski