Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-28712 Introduce Shipment + Service Points IG #1884

Conversation

AsonUnique
Copy link
Contributor

@AsonUnique AsonUnique added tech review needed PR needs tech review new PR contains a new document 202400 PR contains document for the upcoming release 202400 labels May 30, 2023
@AsonUnique AsonUnique self-assigned this May 30, 2023
abitskil
abitskil previously approved these changes May 30, 2023
andriispryker
andriispryker previously approved these changes May 30, 2023
Copy link
Contributor

@andriispryker andriispryker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@VadymSachenko VadymSachenko dismissed stale reviews from andriispryker and abitskil via 3f641ad May 31, 2023 08:24
@VadymSachenko VadymSachenko added in TW review PR is in review by a technical writer and removed tech review needed PR needs tech review labels Jun 1, 2023
@@ -0,0 +1,8 @@
---
title: Install the Shipment + Service Points feature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the included file's name, IG's name, and the title must be identic. In file names, it is "service-point" and the title says "service points"? Chose the proper one and adjust the title or file names accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed file names 👍

…ry-type-service-type-connector-ig' into feature/cc-28712/cc-28724-delivery-type-service-type-connector-ig
@VadymSachenko VadymSachenko added ready for merge The PR can be merged and removed in TW review PR is in review by a technical writer labels Jun 1, 2023
@VadymSachenko VadymSachenko merged commit 8409715 into master Jun 1, 2023
@VadymSachenko VadymSachenko deleted the feature/cc-28712/cc-28724-delivery-type-service-type-connector-ig branch June 1, 2023 08:08
@AlexSlawinski AlexSlawinski removed ready for merge The PR can be merged 202400 PR contains document for the upcoming release 202400 labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new PR contains a new document
Development

Successfully merging this pull request may close these issues.

5 participants