Install the Shipment feature #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmiseev
previously approved these changes
May 25, 2023
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
| 1. Fill the `spy_shipment_type`, `spy_shipment_type_store` tables with data. | ||
| 2. Run the `console publish:trigger-events -r shipment_type` command. | ||
| 3. Make sure that the `spy_shipment_type_storage` table has been filled with respective data. | ||
| 4. Make sure that, in your system, storage entries are displayed with `kv:shipment_type:{store}:{shipment_type_id}` mask. |
There was a problem hiding this comment.
Shouldn't we add an explanation/descripton of the placeholders ({shipment_type_id} and {store}?
Suggested change
| 4. Make sure that, in your system, storage entries are displayed with `kv:shipment_type:{store}:{shipment_type_id}` mask. | |
| 4. Make sure that, in your system, storage entries are displayed with `kv:shipment_type:{store}:{shipment_type_id}` mask. The {store} placeholder stands for {add explanation}, and {shipment_type_id} stands for {add explanation}. |
There was a problem hiding this comment.
I think it's not necessary because explanations will not bring any additional value. These are standard placeholders for search/storage modules so they are clear for other developers.
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
_includes/pbc/all/install-features/202304.0/install-the-shipment-feature.md
Outdated
Show resolved
Hide resolved
VadymSachenko
approved these changes
May 31, 2023
added 4 commits
June 1, 2023 09:41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview