Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixathon: Add image alt text #2

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amansilla
Copy link
Member

@amansilla amansilla commented Oct 11, 2024

PR Description

This PR and all included in Core PRs enable Spryker users to set HTML alt text for product images in small and large version.

Steps before you submit a PR

  • Please add tests for the code you add if it's possible.
  • Please check out our contribution guide: https://docs.spryker.com/docs/dg/dev/code-contribution-guide.html
  • Add a contribution-license-agreement.txt file with the following content:
    I hereby agree to Spryker\'s Contribution License Agreement in https://github.com/spryker/product-image/blob/HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH/CONTRIBUTING.md.

This is a mandatory step to make sure you are aware of the license agreement and agree to it. HASH_OF_COMMIT_YOU_ARE_BASING_YOUR_BRANCH_FROM_MASTER_BRANCH is a hash of the commit you are basing your branch from the master branch. You can take it from commits list of master branch before you submit a PR.

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

@amansilla amansilla changed the title Add image alt text Fixathon: Add image alt text Oct 11, 2024
Comment on lines +44 to +45
<column name="alt_text_small" type="VARCHAR" size="255" required="false"/>
<column name="alt_text_large" type="VARCHAR" size="255" required="false"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ATM it's major change for the module according to our current rules (each change of DB structure must trigger major release). For minor release, the code should be written in the way the module should work correctly with the old DB structure without new fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants