Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add facades for all managers #94

Merged
merged 7 commits into from
Jan 31, 2025
Merged

feat: Add facades for all managers #94

merged 7 commits into from
Jan 31, 2025

Conversation

ollieread
Copy link
Member

This PR is all about facades. While I don't particularly like them, and avoid using them at all costs, I recognise that others will like them.

This PR does the following:

  • Updates the Sprout facade to reflect the previous refactors
  • Adds an Overrides facade for the ServiceOverrideManager class
  • Adds a Providers facade for the TenantProviderManager class
  • Adds a Tenancies facade for the TenancyManager class

@ollieread ollieread self-assigned this Jan 31, 2025
@ollieread ollieread added type: feat New feature status: accepted The issue has been accepted/acknowledged and is being actioned or will be labels Jan 31, 2025
@ollieread ollieread added this to the V1 Release milestone Jan 31, 2025
@ollieread ollieread linked an issue Jan 31, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (7f831b9) to head (dd223c4).
Report is 1 commits behind head on 1.x.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##                1.x      #94      +/-   ##
============================================
+ Coverage     88.24%   88.30%   +0.06%     
- Complexity      557      561       +4     
============================================
  Files            65       69       +4     
  Lines          1557     1565       +8     
============================================
+ Hits           1374     1382       +8     
  Misses          183      183              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ollieread ollieread merged commit d2e1658 into 1.x Jan 31, 2025
4 checks passed
@ollieread ollieread deleted the feat/facades branch January 31, 2025 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: accepted The issue has been accepted/acknowledged and is being actioned or will be type: feat New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more facades for Sprouts core components
1 participant