Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Redis session expiration entry deletion #1800

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix Redis session expiration entry deletion #1800

merged 1 commit into from
Mar 12, 2021

Conversation

swurzinger
Copy link
Contributor

fixes redis session expiration entry deletion

see #1799 for details

@pivotal-issuemaster
Copy link

@swurzinger Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@swurzinger swurzinger mentioned this pull request Mar 11, 2021
Closed
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Mar 11, 2021
@pivotal-issuemaster
Copy link

@swurzinger Thank you for signing the Contributor License Agreement!

eleftherias
eleftherias suggested changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@eleftherias eleftherias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @swurzinger!
I have a few requests before I merge this:

  1. Please update the Apache license header to go up to the year 2021 in the modified files
  2. Please add Closes gh-585 to your commit message so that it is automatically linked to the reported issue

@eleftherias eleftherias self-assigned this Mar 12, 2021
@eleftherias eleftherias added in: redis type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Mar 12, 2021
@eleftherias eleftherias mentioned this pull request Mar 12, 2021
Closed
@swurzinger swurzinger force-pushed the fix-redis-session-expiration-entry-deletion branch from a9b08e2 to 0e2a15c Compare March 12, 2021 15:02
@swurzinger
Copy link
Contributor Author

updated license header and commit message as requested

@eleftherias eleftherias merged commit 69285f2 into spring-projects:master Mar 12, 2021
@eleftherias
Copy link
Contributor

Thanks @swurzinger! This is now merged into master.

@eleftherias eleftherias added this to the 2.5.0-RC1 milestone Mar 12, 2021
@swurzinger swurzinger deleted the fix-redis-session-expiration-entry-deletion branch March 12, 2021 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleftherias eleftherias eleftherias requested changes

Assignees

@eleftherias eleftherias

Labels
in: redis type: bug A general bug
Projects
None yet
Milestone
2.5.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@swurzinger @pivotal-issuemaster @eleftherias @spring-projects-issues