Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CheckedCallable.unchecked() for return type #9702

Closed
artembilan opened this issue Dec 9, 2024 · 0 comments
Closed

Fix CheckedCallable.unchecked() for return type #9702

artembilan opened this issue Dec 9, 2024 · 0 comments
Labels
for: backport-to-6.3.x in: core status: backported type: bug
Milestone
6.4.1

Comments

@artembilan
Copy link
Member

Currently the CheckedCallable.unchecked() returns Runnable instead of Callable<T> and its implementation does not return value from the target call() invocation.
Apparently this is a copy/paste artifact from the CheckedRunnable.

To avoid breaking changes, we are going to introduce another method and deprecate this one.
Will be removed in the next 6.5.x version.
@artembilan artembilan added this to the 6.4.1 milestone Dec 9, 2024
spring-builds pushed a commit that referenced this issue Dec 9, 2024
@artembilan @spring-builds
GH-9702: Add CheckedCallable.uncheckedCallable
9fffb5b 
Fixes: #9702
Issue link: #9702

The current `CheckedCallable.unchecked()` returns `Runnable`, which is not an expectation.

* Deprecate `CheckedCallable.unchecked()` in favor of newly introduced `CheckedCallable.uncheckedCallable()`.
We cannot call it `unchecked()` as well, since `Callable` after erasure becomes similar to class signature as `Runnable`.

(cherry picked from commit 8c22bf6)
@spring-builds spring-builds mentioned this issue Dec 9, 2024
Closed
@artembilan artembilan mentioned this issue Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: backport-to-6.3.x in: core status: backported type: bug
Projects
None yet
Milestone
6.4.1
Development

No branches or pull requests
2 participants
@artembilan @spring-builds