Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema mappings inspection to produce more detailed logs for unexpected Java types #678

Closed
rstoyanchev opened this issue Apr 26, 2023 · 0 comments
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@rstoyanchev
Copy link
Contributor

rstoyanchev commented Apr 26, 2023

As we inspect GraphQL schema types, we also check the return types of corresponding controller methods (or DataFetchers), and nest if necessary for generic parameters such for reactive/async types, paginated types, list types, etc. We perform some sanity checks and detect cases where something is not expected, but generally cannot reliably guard against any unexpected case. That results in reports with missing fields, like with #674.

We can add more detailed DEBUG level logs when we encounter some unexpected case with corresponding Java types to make it easier to track the root cause. In addition, we can change current checks replacing assertions with DEBUG log messages to avoid hard failures out of the box. The decision for a hard failure is instead deferred to the application with #672.

@rstoyanchev rstoyanchev added the type: enhancement A general enhancement label Apr 26, 2023
@rstoyanchev rstoyanchev added this to the 1.2.0 milestone Apr 26, 2023
@rstoyanchev rstoyanchev self-assigned this Apr 26, 2023
@rstoyanchev rstoyanchev changed the title Update schema mappings inspection to produce more detailed logs to debug potential issues Update schema mappings inspection to produce more detailed logs for unexpected Java types Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

1 participant