Correctly set auto-growing array's element #26600
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractNestablePropertyAccessor.processKeyedProperty implementations throw IllegalArgumentException, when the property expression has more than one property key and the last key causes array to grow automatically. This commit fix it.
sbrannen
requested changes
Feb 24, 2021
Thank you very much for your review. I have added a unit test |
sbrannen
approved these changes
Feb 24, 2021
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Feb 25, 2021
sbrannen
pushed a commit
to sbrannen/spring-framework
that referenced
this pull request
Feb 25, 2021
Prior to this commit, the implementation of processKeyedProperty() in AbstractNestablePropertyAccessor resulted in a `java.lang.IllegalArgumentException: array element type mismatch` when the property expression had more than one property key and the last key should cause the array to grow automatically. For example, given a property `int[][] multiArray` and property expression `multiArray[1][3]`, the `processKeyedProperty()` method created a new array object and assigned it to `multiArray`; whereas, the new array object should have be assigned to `multiArray[1]`. This commit fixes this issue. Closes spring-projectsgh-26600
sbrannen
added a commit
to sbrannen/spring-framework
that referenced
this pull request
Feb 25, 2021
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Closed
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Prior to this commit, the implementation of processKeyedProperty() in AbstractNestablePropertyAccessor resulted in a `java.lang.IllegalArgumentException: array element type mismatch` when the property expression had more than one property key and the last key should cause the array to grow automatically. For example, given a property `int[][] multiArray` and property expression `multiArray[1][3]`, the `processKeyedProperty()` method created a new array object and assigned it to `multiArray`; whereas, the new array object should have be assigned to `multiArray[1]`. This commit fixes this issue. Closes spring-projectsgh-26600
lxbzmy
pushed a commit
to lxbzmy/spring-framework
that referenced
this pull request
Mar 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
AbstractNestablePropertyAccessor.processKeyedPropertyresults in ajava.lang.IllegalArgumentException: array element type mismatchwhen the property expression has more than one property key and the last key causes the array to grow automatically.For example, given a property
int[][] multiArray = new int[2][2]and property expressionmultiArray[1][3], theprocessKeyedPropertymethod creates a new array object and assigns it tomultiArray; whereas, the new array object should be assigned tomultiArray[1].