Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flexible Duration value parsing in scheduled tasks #24069

Closed
wants to merge 1 commit into from

Conversation

ilyavy
Copy link

@ilyavy ilyavy commented Nov 25, 2019

Closes gh-22013

Add flexible Duration value parsing in scheduled tasks like in Spring Boot for configuration's consistency.

Reasoning about decisions:

  • The solution is based on a corresponding commit in Spring Boot
  • The logic for parsing delay is not extracted into a separate class following the decision made before by implementors of ScheduledAnnotationBeanPostProcessor class
  • However, it is extracted into a separate method, because now it became more complex, and in my opinion, separating it in a different method simplifies the code
  • Added method parseDelayAsLong is not documented using JavaDoc because as observed from the code private methods are not documented in Spring

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 25, 2019
@mrpiggi
Copy link

mrpiggi commented Nov 2, 2021

Is there any news on this? Will this feature be integrated into the framework or not?

@rstoyanchev rstoyanchev added the in: core Issues in core modules (aop, beans, core, context, expression) label Nov 10, 2021
@snicoll
Copy link
Member

snicoll commented Sep 26, 2022

Thanks for the PR but we prefer to introduce parsing of a Duration as a core support that can be leveraged elsewhere, see #22474

@snicoll snicoll closed this Sep 26, 2022
@snicoll snicoll added status: declined A suggestion or change that we don't feel we should currently apply and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core Issues in core modules (aop, beans, core, context, expression) status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Spring Boot style flexible Duration value parsing [SPR-17481]
5 participants